Clearly this PR is missing some auth goodness being injected into the tests themselves. I'll keep investigating that angle before this is ready for review.

hey @cachedout any updates there?

@belimawr Would you mind re-reviewing this when you have a moment? I would like to get this in somewhat soon and avoid a lengthy round of having to rebase it. :) Thanks!

@KseniaElastic @elastic/observablt-robots as @cachedout is out could you help us out? Seems to be ready to be merged.

@v1v can i have your help here?

@Mergifyio update

@v1v can I have your help here?

I just rebased this PR with the latest changes in the master branch, therefore a new build should happen soon.

Other than that, it might be better if someone from the Beats team take the lead and review those changes.

The review was done by @belimawr so we should be good to go.

update

✅ Branch has been successfully updated

/test

As far I see there are some IntegTest failures for:

• metricbeat-goIntegTest
• x-pack/libbeat-goIntegTest
• x-pack/libbeat-pythonIntegTest

No idea if they are related to this change or flaky tests. I just commented with /test, so a new build will tell the new findings 🤞

OTOH, I have not seen any approval of this particular PR. Mike is on PTO for a while, so either we wait for until then (in a few months) or if this is needed now, maybe @belimawr or someone else within the Beats team can take the ownership of this particular PR and move forward? What do you think?

@belimawr could you give us your approval here?

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack_security_test upstream/xpack_security_test
git merge upstream/master
git push upstream xpack_security_test

As far I see there are some IntegTest failures for:

• metricbeat-goIntegTest
• x-pack/libbeat-goIntegTest
• x-pack/libbeat-pythonIntegTest

No idea if they are related to this change or flaky tests. I just commented with /test, so a new build will tell the new findings crossed_fingers

OTOH, I have not seen any approval of this particular PR. Mike is on PTO for a while, so either we wait for until then (in a few months) or if this is needed now, maybe @belimawr or someone else within the Beats team can take the ownership of this particular PR and move forward? What do you think?

I have the feeling some of those might be flaky tests, I had metricbeat-goIntegTest randomly failing on some PRs totally unrelated to it, a couple of /test did the trick for me.

I'm reviewing the PR and I'll also look into those failing tests.

@v1v @jlind23 a quick question: I see there are some conflicts on this PR, who should fix them? Should I fully take over the PR or just the review?

Either way is fine for me.

@belimawr as @cachedout is out for a couple of more weeks, that would be great if you can take the ownership of this.

@belimawr as @cachedout is out for a couple of more weeks, that would be great if you can take the ownership of this.

I'm on it!

/test